The following document contains the results of Checkstyle. 
| Files | Infos  |
Warnings  |
Errors  |
|---|---|---|---|
| 13 | 0 | 218 | 0 |
| Violation | Message | Line |
|---|---|---|
|
First sentence should end with a period. | 35 |
|
Name 'I_SpringManager' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 41 |
|
First sentence should end with a period. | 43 |
|
Redundant 'public' modifier. | 50 |
|
Expected @param tag for 'cms'. | 50 |
|
Expected @param tag for 'report'. | 50 |
|
Expected @throws tag for 'CmsException'. | 50 |
|
First sentence should end with a period. | 52 |
|
Expected an @return tag. | 58 |
|
Redundant 'public' modifier. | 58 |
|
Expected @param tag for 'beanName'. | 58 |
|
First sentence should end with a period. | 60 |
|
Expected an @return tag. | 65 |
|
Redundant 'public' modifier. | 65 |
|
First sentence should end with a period. | 67 |
|
Redundant 'public' modifier. | 70 |
| Violation | Message | Line |
|---|---|---|
|
Unused import - org.opencms.module.A_CmsModuleAction. | 38 |
|
Utility classes should not have a public or default constructor. | 60 |
|
Name 'm_adminCms' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
|
Name 'm_config' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 64 |
|
Line is longer than 120 characters. | 69 |
|
Parameter adminCms should be final. | 75 |
|
Parameter configurationManager should be final. | 75 |
|
'{' is not preceded with whitespace. | 94 |
|
First sentence should end with a period. | 116 |
|
'{' is not preceded with whitespace. | 120 |
|
'{' is not preceded with whitespace. | 121 |
|
The double-checked locking idiom is broken and should be avoided. | 123 |
|
'{' is not preceded with whitespace. | 123 |
|
Line is longer than 120 characters. | 125 |
|
First sentence should end with a period. | 141 |
|
Parameter cms should be final. | 149 |
|
Expected @throws tag for 'CmsException'. | 149 |
|
First sentence should end with a period. | 154 |
|
Parameter cms should be final. | 161 |
|
Parameter report should be final. | 161 |
|
Expected @throws tag for 'CmsException'. | 161 |
|
First sentence should end with a period. | 165 |
|
Expected an @return tag. | 171 |
|
Parameter beanName should be final. | 171 |
|
Expected @param tag for 'beanName'. | 171 |
|
'{' is not preceded with whitespace. | 171 |
|
First sentence should end with a period. | 175 |
|
Line is longer than 120 characters. | 176 |
|
Expected an @return tag. | 184 |
|
Parameter beanName should be final. | 184 |
|
Expected @param tag for 'beanName'. | 184 |
|
Parameter adminCms should be final. | 184 |
|
Expected @param tag for 'adminCms'. | 184 |
|
Parameter configurationManager should be final. | 185 |
|
Expected @param tag for 'configurationManager'. | 185 |
|
Expected @throws tag for 'CmsException'. | 185 |
|
Expected an @return tag. | 193 |
| Violation | Message | Line |
|---|---|---|
|
Name 'm_opencmsmodulePatterns' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 68 |
|
Name 'm_springconfigLocation' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 70 |
|
Missing a Javadoc comment. | 75 |
|
Parameter digester should be final. | 75 |
|
Line is longer than 120 characters. | 81 |
|
Missing a Javadoc comment. | 87 |
|
Parameter parent should be final. | 87 |
|
'{' is not preceded with whitespace. | 92 |
|
'{' is not preceded with whitespace. | 94 |
|
Missing a Javadoc comment. | 142 |
|
Parameter pattern should be final. | 142 |
|
Missing a Javadoc comment. | 154 |
|
Parameter location should be final. | 154 |
|
'{' is not preceded with whitespace. | 155 |
|
'{' is not preceded with whitespace. | 158 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 55 |
|
Name 'm_config' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
|
Name 'm_adminCms' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 65 |
|
Name 'm_beanFactory' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 67 |
|
Name 'm_loadedModuleNames' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 69 |
|
First sentence should end with a period. | 73 |
|
Parameter adminCms should be final. | 79 |
|
Expected @param tag for 'adminCms'. | 79 |
|
Parameter config should be final. | 79 |
|
Expected @param tag for 'config'. | 79 |
|
Missing a Javadoc comment. | 88 |
|
Parameter cms should be final. | 89 |
|
Parameter report should be final. | 89 |
|
Comment matches to-do format 'TODO:'. | 90 |
|
'{' is not preceded with whitespace. | 96 |
|
'try' is not followed by whitespace. | 101 |
|
'{' is not preceded with whitespace. | 101 |
|
'(' is followed by whitespace. | 145 |
|
Missing a Javadoc comment. | 156 |
|
'{' is not preceded with whitespace. | 162 |
|
'cast' is not followed by whitespace. | 163 |
|
Parameter moduleName should be final. | 176 |
|
First sentence should end with a period. | 180 |
|
Parameter config should be final. | 197 |
|
'{' is not preceded with whitespace. | 199 |
|
'{' is not preceded with whitespace. | 202 |
|
'256' is a magic number. | 204 |
|
'else' is not preceded with whitespace. | 214 |
|
'}' is not followed by whitespace. | 214 |
|
'else' is not followed by whitespace. | 214 |
|
'{' is not preceded with whitespace. | 214 |
|
Must have at least one statement. | 214 |
|
Missing a Javadoc comment. | 234 |
|
Parameter beanName should be final. | 234 |
|
'{' is not preceded with whitespace. | 234 |
|
'{' is not preceded with whitespace. | 235 |
| Violation | Message | Line |
|---|---|---|
|
First sentence should end with a period. | 38 |
|
Parameter adminCms should be final. | 55 |
|
Parameter configurationManager should be final. | 55 |
|
Parameter module should be final. | 56 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 45 |
|
Missing a Javadoc comment. | 51 |
|
Parameter jsp should be final. | 51 |
|
Missing a Javadoc comment. | 55 |
|
Parameter context should be final. | 55 |
|
Parameter req should be final. | 55 |
|
Parameter res should be final. | 55 |
|
Parameter dialog should be final. | 102 |
|
'1024' is a magic number. | 104 |
|
Parameter message should be final. | 127 |
|
'1024' is a magic number. | 128 |
| Violation | Message | Line |
|---|---|---|
|
First sentence should end with a period. | 53 |
|
Parameter adminCms should be final. | 66 |
|
Expected @param tag for 'adminCms'. | 66 |
|
Parameter configLocation should be final. | 66 |
|
Expected @throws tag for 'BeansException'. | 66 |
|
'{' is followed by whitespace. | 67 |
|
Parameter adminCms should be final. | 77 |
|
Expected @param tag for 'adminCms'. | 77 |
|
Parameter configLocations should be final. | 77 |
|
Expected @throws tag for 'BeansException'. | 77 |
|
Parameter adminCms should be final. | 93 |
|
Expected @param tag for 'adminCms'. | 93 |
|
Parameter configLocations should be final. | 93 |
|
Parameter refresh should be final. | 93 |
|
Expected @throws tag for 'BeansException'. | 94 |
|
Parameter adminCms should be final. | 112 |
|
Expected @param tag for 'adminCms'. | 112 |
|
Parameter configLocations should be final. | 112 |
|
Parameter parent should be final. | 112 |
|
Expected @throws tag for 'BeansException'. | 113 |
|
Parameter adminCms should be final. | 132 |
|
Expected @param tag for 'adminCms'. | 132 |
|
Parameter configLocations should be final. | 132 |
|
Parameter refresh should be final. | 132 |
|
Parameter parent should be final. | 133 |
|
Expected @throws tag for 'BeansException'. | 133 |
|
Parameter path should be final. | 160 |
|
'{' is not preceded with whitespace. | 175 |
|
'{' is not preceded with whitespace. | 178 |
|
'{' is not preceded with whitespace. | 185 |
|
'{' is not preceded with whitespace. | 193 |
|
'{' is not preceded with whitespace. | 198 |
|
First sentence should end with a period. | 205 |
|
Parameter path should be final. | 211 |
|
'{' is not preceded with whitespace. | 211 |
| Violation | Message | Line |
|---|---|---|
|
'{' is not preceded with whitespace. | 61 |
|
Missing a Javadoc comment. | 66 |
|
Parameter cmsWidgetDialogImpl should be final. | 66 |
|
Parameter sessionFactory should be final. | 66 |
|
Missing a Javadoc comment. | 72 |
|
'{' is not preceded with whitespace. | 73 |
|
'{' is not preceded with whitespace. | 75 |
|
Missing a Javadoc comment. | 81 |
|
'{' is not preceded with whitespace. | 82 |
|
'{' is not preceded with whitespace. | 84 |
|
Missing a Javadoc comment. | 90 |
|
Parameter uri should be final. | 90 |
|
Missing a Javadoc comment. | 102 |
| Violation | Message | Line |
|---|---|---|
|
Name 'I_CmsDialogSessionWrapper' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 59 |
|
'{' is not preceded with whitespace. | 59 |
|
Missing a Javadoc comment. | 61 |
|
Redundant 'public' modifier. | 61 |
|
Missing a Javadoc comment. | 63 |
|
Redundant 'public' modifier. | 63 |
|
Missing a Javadoc comment. | 65 |
|
Redundant 'public' modifier. | 65 |
|
Missing a Javadoc comment. | 67 |
|
Redundant 'public' modifier. | 67 |
|
Missing a Javadoc comment. | 69 |
|
Redundant 'public' modifier. | 69 |
|
Missing a Javadoc comment. | 71 |
|
Redundant 'public' modifier. | 71 |
| Violation | Message | Line |
|---|---|---|
|
'{' is not preceded with whitespace. | 37 |
|
Missing a Javadoc comment. | 39 |
|
Parameter arg0 should be final. | 39 |
|
Parameter arg1 should be final. | 39 |
|
Missing a Javadoc comment. | 43 |
|
Parameter arg0 should be final. | 43 |
| Violation | Message | Line |
|---|---|---|
|
File contains tab characters (this is the first instance). | 37 |
|
Missing a Javadoc comment. | 37 |
| Violation | Message | Line |
|---|---|---|
|
File contains tab characters (this is the first instance). | 37 |
|
Missing a Javadoc comment. | 37 |
|
'{' is not preceded with whitespace. | 37 |
| Violation | Message | Line |
|---|---|---|
|
Class SessionUtil should be declared as final. | 70 |
|
First sentence should end with a period. | 73 |
|
Expected an @return tag. | 87 |
|
Parameter sessionFactory should be final. | 87 |
|
Expected @param tag for 'sessionFactory'. | 87 |
|
Parameter action should be final. | 87 |
|
Expected @param tag for 'action'. | 87 |
|
Expected @throws tag for 'TransactionException'. | 87 |
|
'{' is not preceded with whitespace. | 95 |
|
'try' is not followed by whitespace. | 102 |
|
'{' is not preceded with whitespace. | 102 |
|
'catch' is not preceded with whitespace. | 104 |
|
'}' is not followed by whitespace. | 104 |
|
'{' is not preceded with whitespace. | 104 |
|
'finally' is not preceded with whitespace. | 106 |
|
'}' is not followed by whitespace. | 106 |
|
'finally' is not followed by whitespace. | 106 |
|
'{' is not preceded with whitespace. | 106 |
|
'{' is not preceded with whitespace. | 108 |
|
Parameter sessionFactory should be final. | 119 |
|
'{' should be on the previous line. | 120 |
|
Parameter sessionFactory should be final. | 125 |
|
'{' should be on the previous line. | 126 |
|
'!=' is not preceded with whitespace. | 128 |
|
'!=' is not followed by whitespace. | 128 |
|
'{' should be on the previous line. | 129 |
